[Webkit-unassigned] [Bug 108083] [GTK] Building fails in an armv5tel board

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=108083





--- Comment #5 from Adrian Perez <aperez at igalia.com>  2013-01-29 04:39:34 PST ---
(In reply to comment #4)
> (From update of attachment 184983 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=184983&action=review
> 
> > Tools/Scripts/webkitdirs.pm:1323
> > +    return $Config{archname} =~ /^arm(-|v[567])/;
> 
> Would it be sufficient to match a string that begins with "arm-" or "armv"? In particular, would it be sufficient to match a string that begins with "armv" as opposed to {armv5, armv6, armv7}?

After thinking a bit more about this, I think you are right: it may
be better to go for the broader /^arm[v-]/ regexp here, so it won't
be needed in the future to edit this if some new ARM incarnation
happens to be reported e.g. as “armv8” (or whatever the version is).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.