[Webkit-unassigned] [Bug 108149] Coordinated Graphics : Move CoordinatedGraphics related files to WebCore

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=108149





--- Comment #5 from Jae Hyun Park <jae.park at company100.net>  2013-01-28 23:37:20 PST ---
(In reply to comment #3)
> (From update of attachment 185162 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=185162&action=review
> 
> Apart from some rename suggestions, this seems to be going in the right direction for me.
> The next step would be to remove most of the stuff from CoordinatedGraphicsArgumentCoders.
> 
> Anders, Simon, your feedback is of course welcome.
> 
> > Source/WebCore/ChangeLog:24
> > +        3. WebCustomFilterProgram and WebCustomFilterOperation is moved to WebCore in
> 
> They should be renamed CoordinatedCustom*, the Web prefix is only for WebKit/WebKit2.
> 
> > Source/WebCore/ChangeLog:239
> > +        (WebCore::LayerTreeRenderer::dispatchOnMainThread):
> 
> I think LayerTreeRenderer should be renamed TextureMapperScene.

(In reply to comment #4)
> (From update of attachment 185162 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=185162&action=review
> 
> > Source/WebCore/ChangeLog:17
> > +        1. Removing CoordinatedLayerTreeHost dependency from LayerTreeRenderer. This
> > +        patch introduces LayerTreeRendererClient, which is implemented in
> > +        CoordinatedLayerTreeHost. LayerTreeRenderer uses this client, instead of using
> > +        CoordinatedLayerTreeHost directly.
> 
> Maybe we should do this first, with a separate patch.

Thanks for the review! 
In the separate patch that introduces LayerTreeRendererClient, should I just rename LayerTreeRenderer to TextureMapperScene?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.