[Webkit-unassigned] [Bug 108121] New: [WK2] Enable fullscreen request from UiProcess (i.e. user command)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=108121

           Summary: [WK2] Enable fullscreen request from UiProcess (i.e.
                    user command)
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebKit2
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: bruno.abinader at basyskom.com


While implementing fullscreen/window toggle (F11) in EFL's MiniBrowser, I've noticed there is no way other than using JS to request full screen view. This bug intends to implement a method to allow UIProcess (i.e. a user command flag or keyboard key associated to fullscreen toggle) to request full screen view to WebProcess, which handles the necessary user authorization request (accept/deny). The workflow works like this:

1. UIProcess generates a call to WebFullScreenManagerProxy::requestEnterFullScreen()
2. WebFullScreenManagerProxy::requestEnterFullScreen() sends a message to WebProcess' WebFullScreenManager::requestEnterFullScreen()
3. The latter calls a public function from its own class WebFullScreenManager::enterFullScreenForElement(element), with element being the core page's element document.
4. User authorization modal dialog shows as expected, with accept/deny callbacks correctly toggling fullscreen/window modes.

Besides that, the already-implemented WebProcess' WebFullScreenManager::requestExitFullScreen() has been modified to use exitEnterFullScreen() (which uses InjectedBundle's code), following code design and avoiding issues when fullscreen was called from JS (clicking on 'deny' wasn't actually triggering window mode).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.