[Webkit-unassigned] [Bug 106842] adding support for DiscardablePixelRef for caching lazily decoded images

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=106842





--- Comment #83 from Min Qin <qinmin at chromium.org>  2013-01-28 13:35:19 PST ---
(From update of attachment 184886)
View in context: https://bugs.webkit.org/attachment.cgi?id=184886&action=review

>> Source/WebCore/platform/graphics/chromium/DiscardablePixelRef.cpp:36
>> +const SkString labelDiscardable("discardable");
> 
> this looks like it generates a static initializer - can you check if it does and fix it if so?

Changed this to const char*.
And use DEFINE_STATIC_LOCAL in isDiscardable().
The problem is that DiscardablePixelRefAllocator::allocPixelRef is not protected by mutex, but isDiscardable() is protected by mutex in ImageDecodingStore. So using DEFINE_STATIC_LOCAL in isDiscardable() is fine, and using the const char* in allocPixelRef() is also fine.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.