[Webkit-unassigned] [Bug 91440] Implement 'vmin' and 'vmax' from CSS3 values and units

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=91440





--- Comment #5 from Uday Kiran <udaykiran at motorola.com>  2013-01-28 10:35:47 PST ---
(From update of attachment 184907)
View in context: https://bugs.webkit.org/attachment.cgi?id=184907&action=review

Thanks for review.

>>>> Source/WebCore/css/CSSParser.cpp:1642
>>>> +           || (value->unit >= CSSPrimitiveValue::CSS_VW && value->unit <= CSSPrimitiveValue::CSS_VMAX)
>>> 
>>> Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
>> 
>> Should I fix this?
> 
> I would since you're here.  I suggested the same on the ch unit bug.

Ok I will fix this.

>> Source/WebCore/css/CSSPrimitiveValue.idl:52
>> +    const unsigned short CSS_VMAX       = 29;
> 
> Do these values need to be kept in sync with the enum in CSSPrimitiveValue.h?  If so, can we add a COMPILE_ASSERT to enforce it?

CSS_DPPX, CSS_DPI, CSS_DPCM are not present in idl but present in CSSPrimitiveValue.h header file. So I think all values are not mandatory.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.