[Webkit-unassigned] [Bug 107538] [GTK] [WTR] layoutTestController.pathToLocalResource needs to be updated

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jan 28 07:33:11 PST 2013


https://bugs.webkit.org/show_bug.cgi?id=107538


Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #183953|review?                     |review+, commit-queue-
               Flag|                            |




--- Comment #3 from Martin Robinson <mrobinson at webkit.org>  2013-01-28 07:35:09 PST ---
(From update of attachment 183953)
View in context: https://bugs.webkit.org/attachment.cgi?id=183953&action=review

Nice work. This looks good to me. I have just pointed out a style nit below. If you like, I can fix this and land it or you can upload a new patch.

> Tools/WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:35
>  #include "InjectedBundle.h"
> +
> +#include "InjectedBundleUtilities.h"
> +
>  #include <glib.h>
> +#include <wtf/gobject/GOwnPtr.h>

Keep all these includes together as one solid block.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list