[Webkit-unassigned] [Bug 107541] [GTK] [WTR] Move ActivateFontsGtk::getTopLevelPath() to utilities file

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=107541





--- Comment #2 from Martin Robinson <mrobinson at webkit.org>  2013-01-28 07:33:06 PST ---
(From update of attachment 183948)
View in context: https://bugs.webkit.org/attachment.cgi?id=183948&action=review

> Tools/WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:36
> +#include "InjectedBundleUtilities.h"
> +
>  #include <fontconfig/fontconfig.h>

There should be no newline gap here between system includes and relative includes.

> Tools/WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:37
> +namespace Util {

Probably the WTR namespace is enough and you can avoid the Util namespace.

> Tools/WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.h:48
> +/**
> + * Returns the top level directory from WEBKIT_TOP_LEVEL environment
> + * variable.
> + *
> + * If the environment variable wasn't provided then assume we were built
> + * into WebKitBuild/Debug or WebKitBuild/Release. Obviously this will fail
> + * if the build directory is non-standard, but we can't do much more about
> + * this.
> + *
> + * @return the top level path.
> + */
> +CString topLevelPath();

We don't typically add gtkdoc comments for non-API methods.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.