[Webkit-unassigned] [Bug 107931] [EFL][WK2] Introduce a WebView class as counterpart for WKViewRef

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=107931





--- Comment #11 from Mikhail Pozdnyakov <mikhail.pozdnyakov at intel.com>  2013-01-28 02:35:32 PST ---
(From update of attachment 184956)
View in context: https://bugs.webkit.org/attachment.cgi?id=184956&action=review

LGTM

> Source/WebKit2/UIProcess/API/C/efl/WKView.cpp:65
> +Evas_Object* WKViewGetEvasObject(WKViewRef viewRef)

could we have a comment, saying it is temporary?

> Source/WebKit2/UIProcess/API/efl/EwkView.h:105
> +class WebView {

guess should be inherited from APIObject (but maybe not necessary within the current patch).

> Source/WebKit2/UIProcess/API/efl/EwkView.h:112
> +    WKPageRef pageRef() { return toAPI(m_webPageProxy.get()); }

const method?

> Source/WebKit2/UIProcess/API/efl/EwkView.h:118
> +    // FIXME: Remove when possible.

right

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.