[Webkit-unassigned] [Bug 108004] [chromium] WebConsoleMessage is missing LevelDebug (chromium bug 172416)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=108004





--- Comment #9 from Kevin Day <kevinday at gmail.com>  2013-01-26 10:54:30 PST ---
I checked for similar problems in other platforms:


blackberry:

The only place MessageLevel is referenced is in ChromeClientBlackBerry::addMessageToConsole, where that parameter is completely ignored. There is no blackberry specific enum for message levels. Blackberry also doesn't have an AssertMatchingEnums.

chromium:

Updated AssertMatchingEnums.cpp to test these enums.

efl:

The only place MessageLevel is referenced is in ChromeClientEfl::addMessageToConsole, where that parameter is completely ignored. There is no efl specific enum for message levels. efl does have an AssertMatchingEnums, but there is no webkit levels enum to add to it.

gtk:

exactly the same as efl

mac:

The only place MessageLevel is referenced is in WebChromeClient::addMessageToConsole. It is actually used here, but there is no matching enum - the only thing that's done with it is to call stringForMessageLevel.

qt:

exactly the same as efl, except that it has no AssertMatchingEnums

win:

exactly the same as efl, except that it has no AssertMatchingEnums

wince:

exactly the same as efl, except that it has no AssertMatchingEnums

wx:

MessageLevel is used in ChromeClientWx::addMessageToConsole, and is cast to static_cast<WebViewConsoleMessageLevel>(level) similar to how Chromium handles this. WebViewConsoleMessageLevel is also missing a DebugMessageLevel, which is an easy fix. I don't have a wx development environment set up though, so I'm not sure if anything higher up would need to be patched to allow for this. Nothing in WebKit/wx actually ever uses the level. It's stuffed into an m_level variable inside WebViewConsoleMessageEvent, but nothing inside WebKit uses that. I don't know if this is safe to change or not.



TL;DR: Everything except wx looks okay, but I don't have enough familiarity with wx to know if it's safe to change.

I updated my patch to include an AssertMatchingEnums test for chromium.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.