[Webkit-unassigned] [Bug 108007] New: Stop defining PLATFORM(MAC) when building for PLATFORM(IOS) and PLATFORM(IOS_SIMULATOR)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Jan 26 10:47:14 PST 2013


https://bugs.webkit.org/show_bug.cgi?id=108007

           Summary: Stop defining PLATFORM(MAC) when building for
                    PLATFORM(IOS) and PLATFORM(IOS_SIMULATOR)
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Web Template Framework
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: ddkilzer at webkit.org
                CC: mjs at apple.com, darin at apple.com, sam at webkit.org,
                    abarth at webkit.org, laszlo.gombos at webkit.org,
                    benjamin at webkit.org


We should stop defining PLATFORM(MAC) when building for PLATFORM(IOS) and PLATFORM(IOS_SIMULATOR) for the following reasons:

- Require contributors to be explicit about whether code supports both Mac and iOS.
- Make it explicit about which code supports iOS (so searching for "PLATFORM(IOS)" is meaningful).
- Make Mac-only code use "PLATFORM(MAC)" instead of "PLATFORM(MAC) && !PLATFORM(IOS)".
- Make it obvious when an ENABLE() or USE() macro should replace "PLATFORM(MAC) || PLATFORM(IOS)".
- Make the case in the future for a PLATFORM(_FOO_) macro that represents "PLATFORM(MAC) || PLATFORM(IOS)".

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list