[Webkit-unassigned] [Bug 107364] Improve PageVisibility API with enums

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=107364





--- Comment #7 from Joseph Pecoraro <joepeck at webkit.org>  2013-01-24 18:51:12 PST ---
(In reply to comment #4)
> (From update of attachment 183858 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=183858&action=review
> 
> > Source/WebKit/mac/WebView/WebViewPrivate.h:118
> > +// This needs to be in sync with WebCore::PageVisibilityState.
> 
> Since you cast between two type, a good way to enforce correctness is to have one COMPILE_ASSERT() per enum value in your .mm file.

Since I didn't see any other examples of WebKit API casting types to WebCore types, but I did find examples of core() and kit() functions converting between the two, I went with a core() approach.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.