[Webkit-unassigned] [Bug 107868] REGRESSION(140571): Crash in ScrollingCoordinator::mainThreadScrollingReasons during Frame::createView

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=107868





--- Comment #3 from Beth Dakin <bdakin at apple.com>  2013-01-24 15:09:42 PST ---
(In reply to comment #2)
> What 'bout this?
> 
> diff --git a/Source/WebCore/page/scrolling/ScrollingCoordinator.cpp b/Source/WebCore/page/scrolling/ScrollingCoordinat
> index c17cc36..f12c280 100644
> --- a/Source/WebCore/page/scrolling/ScrollingCoordinator.cpp
> +++ b/Source/WebCore/page/scrolling/ScrollingCoordinator.cpp
> @@ -449,6 +449,8 @@ bool ScrollingCoordinator::hasVisibleSlowRepaintViewportConstrainedObjects(Frame
>  MainThreadScrollingReasons ScrollingCoordinator::mainThreadScrollingReasons() const
>  {
>      FrameView* frameView = m_page->mainFrame()->view();
> +    if (!frameView)
> +        return static_cast<MainThreadScrollingReasons>(0);
> 
>      MainThreadScrollingReasons mainThreadScrollingReasons = (MainThreadScrollingReasons)0;
> 
> 
> ?

I still think it's cray-zay that we can end up calling updateScrollbars() this early on in the construction of a FrameView, but I think this change is okay.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.