[Webkit-unassigned] [Bug 107829] Web Inspector: support JavaScript variable mutation in protocol and V8 bindings
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jan 24 10:32:29 PST 2013
https://bugs.webkit.org/show_bug.cgi?id=107829
--- Comment #6 from Peter Rybin <prybin at chromium.org> 2013-01-24 10:34:23 PST ---
> > Source/WebCore/inspector/InjectedScriptSource.js:595
> > + setter = function(scopeIndex, variableName, newValue) {
>
> style: { on next line
Done
> > Source/WebCore/inspector/InjectedScriptSource.js:603
> > + setter = function(scopeIndex, variableName, newValue) {
>
> please use InjectedScriptHost.setFunctionVariableValue.bind(InjectedScriptHost,... instead
Done
> > Source/WebCore/inspector/Inspector.json:2847
> > + { "name": "scopeNumber", "type": "integer", "description": "0-based number of scope as was listed in scope chain. Only 'local', 'closure' and 'catch' scope types are allowed. Other scopes could be manipulated manually." },
> Please add a note to the changelog on why you don't want to deal with "with" scopes.
Done
> > Source/WebCore/inspector/Inspector.json:2850
> > + ],
> Please hide this from the public protocol.
Done
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list