[Webkit-unassigned] [Bug 107829] Web Inspector: support JavaScript variable mutation in protocol and V8 bindings

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=107829





--- Comment #3 from Yury Semikhatsky <yurys at chromium.org>  2013-01-24 09:01:26 PST ---
(From update of attachment 184509)
View in context: https://bugs.webkit.org/attachment.cgi?id=184509&action=review

> Source/WebCore/inspector/InjectedScriptSource.js:595
> +            setter = function(scopeIndex, variableName, newValue) {

style: { on next line

> Source/WebCore/inspector/InjectedScriptSource.js:603
> +            setter = function(scopeIndex, variableName, newValue) {

please use InjectedScriptHost.setFunctionVariableValue.bind(InjectedScriptHost,... instead

> Source/WebCore/inspector/Inspector.json:2847
> +                    { "name": "scopeNumber", "type": "integer", "description": "0-based number of scope as was listed in scope chain. Only 'local', 'closure' and 'catch' scope types are allowed. Other scopes could be manipulated manually." },

Please add a note to the changelog on why you don't want to deal with "with" scopes.

> Source/WebCore/inspector/Inspector.json:2850
> +                ],

Please hide this from the public protocol.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.