[Webkit-unassigned] [Bug 107804] [mac] ImageBuffer should create accelerated buffers for small canvases, but we shouldn't force them to create compositing layers

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 24 08:36:53 PST 2013


https://bugs.webkit.org/show_bug.cgi?id=107804


Simon Fraser (smfr) <simon.fraser at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #184441|review?                     |review-
               Flag|                            |




--- Comment #4 from Simon Fraser (smfr) <simon.fraser at apple.com>  2013-01-24 08:38:46 PST ---
(From update of attachment 184441)
View in context: https://bugs.webkit.org/attachment.cgi?id=184441&action=review

>> Source/WebCore/rendering/RenderLayerCompositor.cpp:1907
>> +        return canvas->renderingContext() && canvas->renderingContext()->isAccelerated() && (canvas->size().area() > canvasAreaThresholdRequiringCompositing);
> 
> This is shared code, I wonder if this is reasonable for everyone...

We should probably #ifdef it. Maybe USE_COMPOSITING_FOR_SMALL_CANVASES or something, disabled for PLATFORM(MAC) and PLATFORM(IOS).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list