[Webkit-unassigned] [Bug 107444] Add error checking into OpenCL version of SVG filters.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=107444





--- Comment #6 from Zoltan Herczeg <zherczeg at webkit.org>  2013-01-24 06:56:11 PST ---
> My unhappiness with the #ifdefs should not prevent this change from landing. > I will create a separate bug.

Thank you.

> I interpret this to mean that you want a special form of image buffer for
> this case (some filter ops) but you do not want all ImageBuffer operations to
> go through the new code path. You would still like to have the existing software image buffer implementation.

Exactly. I would not touch the existing ImageBuffer implementation, since it is full of platform specific code. The OpenCL code path is only for filters (at the moment). When OpenCL is enabled and working, it replaces the entire buffer chain with its own buffer type. If any error occures, it fallback to the software code path, and never tries OpenCL again (should not happen in practice).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.