[Webkit-unassigned] [Bug 107693] [WK2][EFL] Remove unneeded private methods

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 23 14:52:30 PST 2013


https://bugs.webkit.org/show_bug.cgi?id=107693


Benjamin Poulain <benjamin at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #184234|review?                     |review+
               Flag|                            |




--- Comment #4 from Benjamin Poulain <benjamin at webkit.org>  2013-01-23 14:54:22 PST ---
(From update of attachment 184234)
View in context: https://bugs.webkit.org/attachment.cgi?id=184234&action=review

> Source/WebKit2/UIProcess/API/efl/EwkViewImpl.cpp:380
> +    if (m_pendingSurfaceResize || !m_evasGLSurface) {

The way the state is handled before coming here is madness.

I am not sure you even need "|| !m_evasGLSurface". I think some clarifying of the state would be beneficial.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list