[Webkit-unassigned] [Bug 40300] Web Inspector: [JSC] implement script source editing

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 23 12:03:26 PST 2013


https://bugs.webkit.org/show_bug.cgi?id=40300


Oliver Hunt <oliver at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #155472|review?                     |review-
               Flag|                            |




--- Comment #88 from Oliver Hunt <oliver at apple.com>  2013-01-23 12:05:17 PST ---
(From update of attachment 155472)
View in context: https://bugs.webkit.org/attachment.cgi?id=155472&action=review

I've redone how compilation works since this patch was put up so a lot of the refactoring can probably go away :-/

> Source/JavaScriptCore/interpreter/Interpreter.cpp:1131
> -                    if (i == 0) {
> +                    if (!i) {

Don't change this, while it's a style violation we don't really like changes just to appease the style bot.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list