[Webkit-unassigned] [Bug 107603] Call XSSAuditor.filterToken() from threaded HTML parser

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=107603


Tony Gentilcore <tonyg at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|tonyg at chromium.org          |webkit-unassigned at lists.web
                   |                            |kit.org




--- Comment #4 from Tony Gentilcore <tonyg at chromium.org>  2013-01-23 11:12:26 PST ---
This is going to be pretty tricky. Adam and I discussed it offline and came up with the following sketch:
- HTMLDocumentParser creates the XSSAuditor on the main thread
- HTMLDocumentParser calls XSSAuditor::init() on the main thread
- Transfer ownership of the XSSAuditor to the parser thread when the parser thread is created
- Call filterToken() on the parser thread
- XSSAuditor's actions in filterToken()'s didBlockScript block are queued up in the token steam and if the HTMLDocumentParser uses the token, it executes the action on the main thread.

The tricky part is sharing string data, particularly for POST data which may be large. One option is to parse on the main thread for POST data or just for large POST data.

The other question is whether we can break this into multiple patches so it isn't one monolithic switch.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.