[Webkit-unassigned] [Bug 31155] [GStreamer] Implement setPreservesPitch()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=31155





--- Comment #14 from Víctor M. Jáquez L. <vjaquez at igalia.com>  2013-01-23 10:03:40 PST ---
(In reply to comment #13)
> (From update of attachment 184254 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=184254&action=review
> 
> > Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:1815
> > +    GstElement* convert = gst_element_factory_make("audioconvert", 0);
> 
> I think we can safely assume that the elements shipped in gstreamer -core and -plugins-base are available at least. For scaletempo I agree it makes sense to check its presence but the rest, it's a bit overkill, IMHO :)
> 
> > Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:1829
> > +        GST_WARNING("Failed to create audioresample");
> 
> C/P error here

Ok. I'll remove the checks for the elements, except the scaletempo one.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.