[Webkit-unassigned] [Bug 104662] [EFL][GTK][Mac][Chromium] Share accessibility LayoutTest

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=104662





--- Comment #10 from Mario Sanchez Prada <mario at webkit.org>  2013-01-23 05:37:26 PST ---
(In reply to comment #8)
> Created an attachment (id=184194)
 --> (https://bugs.webkit.org/attachment.cgi?id=184194&action=review) [details]
> patch proposition
> 
> I've moved some test from GTk and Mac to new catalog LayoutTests/accessibility/atk
> and edited TestExpectations in mac, gtk and efl.
> 
> Please make opinion about that move.

What is the reason for that move? I mean, are you sure you won't break other platforms (e.g. mac, chromium) by doing that move?

I agree with the renaming of gtk/ -> atk/, but I think moving many tests from LayoutTests/platform/[gtk|mac]/accessibility to LayoutTests/accessibility could bring undesired results (and in any case, they probably should go in a separate patch)

Besides, I don't see in the new patch any usage of testRunner.platformName. Perhaps you just don't need it after all?

My 2 cents

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.