[Webkit-unassigned] [Bug 107655] [v8] prepare SerializedScriptValue for transition to Latin-1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 23 03:22:51 PST 2013


https://bugs.webkit.org/show_bug.cgi?id=107655





--- Comment #3 from Dan Carney <dcarney at google.com>  2013-01-23 03:24:43 PST ---
(From update of attachment 184190)
View in context: https://bugs.webkit.org/attachment.cgi?id=184190&action=review

>> LayoutTests/platform/chromium/fast/storage/serialized-script-value.html:13
>> +var curVer = 0x02ff;
> 
> Nit: curVer => currentVersion
> 
> WebKit uses a fully qualified variable name.

I used curVer to have 6 characters and keep all the byte arrays nicely lined up.

>> LayoutTests/platform/chromium/fast/storage/serialized-script-value.html:28
>> +                  [ curVer, 0x003f, 0x3f6f, 0x5301, 0x6603,
> 
> Won't this change lose compatibility for already stored serialized script values (e.g. localStorage)? (I just wanted to confirm that it's OK to change the serialized results.)

This change is backwards but not forwards compatible.  If i'm reading SerializedScriptValue.cpp correctly, this bumping the version number is the correct way to do this transition.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list