[Webkit-unassigned] [Bug 74358] prepare-Changelog should support updating the list of changed files

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=74358





--- Comment #10 from Timothy Loh <timloh at chromium.org>  2013-01-22 22:41:37 PST ---
(In reply to comment #9)
> (From update of attachment 184122 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=184122&action=review
> 
> This looks OK to me.  There are some small mentions below.
> 
> > Tools/Scripts/webkitpy/tool/steps/preparechangelog.py:64
> > +    def _resolve_existing_entry(self, changelog_path):
> 
> This function is a bit long for my tastes.  I'm not sure how I would break it up, possibly into _update_date_line and _update_description functions.

I'll split this into reading/writing the ChangeLog and merging the entries.

> > Tools/Scripts/webkitpy/tool/steps/preparechangelog.py:74
> > +            entries_gen = ChangeLog.parse_entries_from_file(changelog_file)
> 
> self. will make this easier to mock/override when we finally make this class ues Filesystem and thus be more testable.

We're in PrepareChangeLog here, not ChangeLog.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.