[Webkit-unassigned] [Bug 74358] prepare-Changelog should support updating the list of changed files

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 22 20:50:32 PST 2013


https://bugs.webkit.org/show_bug.cgi?id=74358





--- Comment #6 from Timothy Loh <timloh at chromium.org>  2013-01-22 20:52:24 PST ---
(In reply to comment #5)
> (From update of attachment 184108 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=184108&action=review
> 
> > Tools/Scripts/webkitpy/tool/steps/preparechangelog.py:65
> > +    @staticmethod
> > +    def _resolve_existing_entry(changelog_path):
> 
> No need for statics.  We really don't use @staticmethod in webkitpy.  Maybe we should, but historically it's been a huge testing pain.

Whoops, you'd think I'd remember after getting rid of some yesterday.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list