[Webkit-unassigned] [Bug 107478] Add functions to ChangeLog - parse bug desc/changed functions, delete/prepend entries
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jan 22 16:49:22 PST 2013
https://bugs.webkit.org/show_bug.cgi?id=107478
--- Comment #12 from Timothy Loh <timloh at chromium.org> 2013-01-22 16:51:14 PST ---
(In reply to comment #10)
> (From update of attachment 184053 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=184053&action=review
>
> > Tools/Scripts/webkitpy/common/checkout/changelog.py:450
> > + data = codecs.open(self.path, "r", "utf-8").read()
> > + codecs.open(self.path, "w", "utf-8").write(text + data)
>
> Shouldn't we be using a FileSystem for this? I'm sorry I didn't catch this before. I guess ChangeLog doesn't correctly sit on top of our FileSystem abstraction anyway?
ChangeLog uses the fileinput module (i.e. the real filesystem) throughout, so I thought it would be a bit inconsistent to add functions which use the FileSystem abstraction. Probably using FileSystem would be better though, so I'll see if getting rid of fileinput isn't too messy.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list