[Webkit-unassigned] [Bug 107171] shouldMoveCaretToHorizontalBoundaryWhenPastTopOrBottom should return false on Android
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jan 22 15:09:19 PST 2013
https://bugs.webkit.org/show_bug.cgi?id=107171
--- Comment #25 from Chris Hopman <cjhopman at chromium.org> 2013-01-22 15:11:11 PST ---
(From update of attachment 184048)
View in context: https://bugs.webkit.org/attachment.cgi?id=184048&action=review
>> LayoutTests/editing/selection/test-if-should-move-caret-to-horizontal-boundary-forced-false-expected.txt:4
>> +Caret location: [object Text] XX 0 true
>
> I can't tell what "true" means here. In general, the test output should be self explanatory such that
> someone who has never looked at the test should be able to tell what the test is testing and whether it's passing or failing and why.
Ok, how about just not outputting isCollapsed? This test doesn't actually care about it, and if it's ever false then there is certainly something more fundamental wrong with selection.
But, on that note, do you think I should label these other values (anchorNode, anchorNode.data, anchorOffset)?
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list