[Webkit-unassigned] [Bug 107478] Add functions to ChangeLog - parse bug desc/changed functions, delete/prepend entries

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 22 14:39:41 PST 2013


https://bugs.webkit.org/show_bug.cgi?id=107478


Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #183851|review?, commit-queue?      |review+, commit-queue-
               Flag|                            |




--- Comment #7 from Eric Seidel <eric at webkit.org>  2013-01-22 14:41:33 PST ---
(From update of attachment 183851)
View in context: https://bugs.webkit.org/attachment.cgi?id=183851&action=review

Aside from the self/cls confusion (which I likely lead you to), this looks fine.  You'll need to post the final patch with 'cls' replacing 'self' where necessary.

> Tools/Scripts/webkitpy/common/checkout/changelog.py:114
> +    def _parse_reviewer_text(self, text):

This is called "cls" when it's a class method.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list