[Webkit-unassigned] [Bug 107171] shouldMoveCaretToHorizontalBoundaryWhenPastTopOrBottom should return false on Android

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=107171





--- Comment #22 from Ryosuke Niwa <rniwa at webkit.org>  2013-01-22 12:29:54 PST ---
(From update of attachment 184024)
View in context: https://bugs.webkit.org/attachment.cgi?id=184024&action=review

> LayoutTests/editing/selection/test-if-should-move-caret-to-horizontal-boundary-forced-false-expected.txt:3
> +clickAt(782, 94)

Doesn't this coordinate depend on how the text above wrap? You should probably hide the description text during the test so that it won't affect the clicked coordinate and make it platform dependent.

> LayoutTests/editing/selection/test-if-should-move-caret-to-horizontal-boundary-forced-false.html:32
> +    var sel = window.getSelection();

Please don't use an abbreviation like sel. Spell out selection.
Also, you don't need window. Simply call getSelection() as in:
var anchorNode = getSelection().anchorNode;
return anchorNode + ' ' + anchorNode.data + ' ' + getSelection().anchorOffset;

You should also check that the resultant selection is collapsed. i.e. getSelection().isCollapsed is true.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.