[Webkit-unassigned] [Bug 102932] [EFL][WK2] Implement context menu in MiniBrowser

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=102932





--- Comment #4 from Michal Pakula vel Rutka <m.pakula at samsung.com>  2013-01-22 00:36:35 PST ---
(From update of attachment 183799)
View in context: https://bugs.webkit.org/attachment.cgi?id=183799&action=review

>> Source/WebKit2/UIProcess/API/efl/ewk_context_menu_item.h:273
>> +EAPI Ewk_Context_Menu *ewk_context_menu_item_parent_menu_get(Ewk_Context_Menu_Item *o);
> 
> Missing *const* keyword in parameter.

Added.

>> Source/WebKit2/UIProcess/API/efl/ewk_context_menu_item_private.h:66
>> +    EwkContextMenu* parentMenu() const { return m_parentMenu; }
> 
> WebKit coding style: The getter should not be const if it returns a non-const pointer.

If I have added const to ewk_context_menu_item_parent_menu_get it has to be left here.

>> Source/WebKit2/UIProcess/API/efl/ewk_context_menu_item_private.h:70
>> +    explicit EwkContextMenuItem(const WebKit::WebContextMenuItemData&, EwkContextMenu* parentMenu);
> 
> Please remove explicit keyword.

Removed.

>> Tools/MiniBrowser/efl/main.c:94
>> +    Evas_Object *context_popup;
> 
> This should probably be initialized to NULL in window_create().

Added.

>> Tools/MiniBrowser/efl/main.c:910
>> +    Ewk_Context_Menu_Item *ewk_item =  (Ewk_Context_Menu_Item *)data;
> 
> extra space after =

OK

>> Tools/MiniBrowser/efl/main.c:1286
>> +    ewk_settings_continuous_spell_checking_enabled_set(EINA_TRUE);
> 
> seems unrelated?

I forgot to remove it after tests.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.