[Webkit-unassigned] [Bug 107498] New: TRANSFORMATION_MATRIX_USE_X86_64_SSE2 broken for 64-bit Windows builds

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=107498

           Summary: TRANSFORMATION_MATRIX_USE_X86_64_SSE2 broken for
                    64-bit Windows builds
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebCore Misc.
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: jschuh at chromium.org
                CC: benjamin at webkit.org, jamesr at chromium.org


Looks like a simple bug in this conditional macro:

72   #if CPU(X86_64) && !PLATFORM(WINDOWS)
73   #define TRANSFORMATION_MATRIX_USE_X86_64_SSE2
74   #endif

The problem is that !PLATFORM(WINDOWS) doesn't do anything. So TRANSFORMATION_MATRIX_USE_X86_64_SSE2 gets defined but the compiler explodes on the alignment specifier. I assume it was meant to be PLATFORM(WIN), but COMPILER(MSVC) is probably more correct.

I could just fix the macro to exclude Windows, but the SSE intrinsics are all supported on Win64. So, is there any reason I can't just add an #if with a __declspec to set the correct alignment and enable this for Win64? (I ask, because at the moment I'm just a few dependencies short of a build I can actually test with on Win64.)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.