[Webkit-unassigned] [Bug 107414] New: Refactor platform-specific code in SpeechSynthesis

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=107414

           Summary: Refactor platform-specific code in SpeechSynthesis
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Accessibility
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: dmazzoni at google.com


See https://bugs.webkit.org/show_bug.cgi?id=107382 for discussion; the idea is to move platform-specific code to the platform directory.

Questions:
* Is it okay to have a method defined in a header file, but have the method implemented differently in different platform source files, without subclassing?
* If not, is there a preferred style for factory classes?
* What's a good example of a module that implements the cross-platform abstraction correctly, in terms of code style? Ideally, pick something that's NOT a core WebCore feature (i.e. some platforms might disable it) because core features tend to be much more complicated or have other requirements.

Finally, could we either document the best practices somewhere, or file bugs to refactor all of the modules that violate this rule? As it is, WebCore has several examples of both approaches so there's no way for a contributor to know that one style is preferred.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.