[Webkit-unassigned] [Bug 107365] Document the list of ports that support Windows

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=107365





--- Comment #5 from Laszlo Gombos <laszlo.gombos at webkit.org>  2013-01-19 01:15:27 PST ---
(In reply to comment #4)
> (In reply to comment #3)
> > (In reply to comment #2)
> > > (From update of attachment 183609 [details] [details] [details])

> The Platform.h change is what I'm confused by. :)  I'm just not sure why it's important to have a list of ports which support windows.  

I do not really know the definite list of PLATFORM()s that support OS(WINDOWS) - I just made a best effort to list them. The only way to know is to run the test in Platform.h in all the bots/ports and see which one fails/who screams. I was thinking that perhaps we should leave this code in there so that the next guy making a similar change would not have this problem. If I made an error in my list of Windows ports than the change in config.h is wrong.

> We don't have the same for any other platform. :)

I can add a list for other OS()s. 

Another example from Platform.h:

#if OS(DARWIN) && !PLATFORM(GTK) && !PLATFORM(QT)
#define ENABLE_PURGEABLE_MEMORY 1
#endif

I do not really know which ports would have ENABLE_PURGEABLE_MEMORY turned on. If I could replace the test with:

#if OS(DARWIN) && (PLATFORM(MAC) || PLATFORM(WX))

than I would find the code more readable and maintainable. 


Not a big deal, I am OK either way, just wanted to make sure that I make my case.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.