[Webkit-unassigned] [Bug 107342] Clean up device scale factor with Skia GraphicsContext

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=107342





--- Comment #5 from Tien-Ren Chen <trchen at chromium.org>  2013-01-18 18:02:23 PST ---
(In reply to comment #4)
> (From update of attachment 183581 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=183581&action=review
> 
> > Source/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp:615
> > +    int rasterScaleFactor = static_cast<int>(lroundf(effectiveScaleComponent(platformContext()->getTotalMatrix())));
> 
> This isn't able to differentiate between page zoom (user hits cmd-+ a few times) and device scale, is it? Like, if I zoom in often enough on a lowdpi screen to get >= 2x zoom, will spell marker size double all of a sudden?

Hmm, I think you're right. It would look bad if the appearance suddenly changes.

My purpose was to make sure composited layer also get high resolution grammar markers. Then I guess the correct way to do it is to set the platform device scale factor somewhere near GraphicsLayerChromium::paint(). I'll discuss with compositor guys to figure out what is the best place.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.