[Webkit-unassigned] [Bug 106699] [Qt] qtwebkit-2.3: crash in gmail on enabling desktop notifications

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=106699


David Rosca <nowrep at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nowrep at gmail.com




--- Comment #6 from David Rosca <nowrep at gmail.com>  2013-01-18 15:42:10 PST ---
>From w3.org:
static void requestPermission(NotificationPermissionCallback callback);

There is one parameter to requestPermission method. However, if this method is called without it, the Callback pointer that is passed to NotificationPresenterClientQt will be invalid and finally will lead to this crash.

The simple "window.webkitNotifications.requestPermission();" should crash it.

I've added two patches, the first checks the validity of callback pointer right before using it, while the second rather prevents adding invalid callback pointer into m_callbacks array.
I'd prefer the behavior of the second patch.

Both patches fixes the crash and enables desktop notifications on gmail.com

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.