[Webkit-unassigned] [Bug 106792] Text Autosizing: don't autosize headers with multiple inline links.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=106792





--- Comment #13 from timvolodine at chromium.org  2013-01-18 09:13:56 PST ---
(From update of attachment 183004)
View in context: https://bugs.webkit.org/attachment.cgi?id=183004&action=review

>> Source/WebCore/ChangeLog:10
>> +        autosized.
> 
> But the code would detect them everywhere on the page right

yes, and that makes it non-trivial to detect those problematic headers so to speak

>> Source/WebCore/rendering/TextAutosizer.cpp:281
>> +    if (containerIsRowOfLinks(container))
> 
> IsCollectionOfLinks? what about oclumns of links? why is that not a problem?

It's more specific than just a collection of links. More like a 'row' of links, because we generally don't want to autosize *any* occurrence of collections of links, only the ones that are header-like, because if they are autosized they get wrapped and look really ugly.
I will upload a new patch shortly which will be more restrictive about what to call a row of links (i.e. a 'header')

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.