[Webkit-unassigned] [Bug 107255] Add explicit keyword to constructors in platform-specific InspectorClient

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jan 18 07:20:10 PST 2013


https://bugs.webkit.org/show_bug.cgi?id=107255


Seokju Kwon <seokju.kwon at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #183446|review?                     |commit-queue?
               Flag|                            |




--- Comment #5 from Seokju Kwon <seokju.kwon at gmail.com>  2013-01-18 07:21:58 PST ---
(From update of attachment 183446)
Fix some coding style issues

Source/WebKit/wince/WebCoreSupport/InspectorClientWinCE.h:37:  The parameter name "webView" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit/gtk/WebCoreSupport/InspectorClientGtk.h:35:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebKit/gtk/WebCoreSupport/InspectorClientGtk.h:42:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Source/WebKit/gtk/WebCoreSupport/InspectorClientGtk.h:51:  The parameter name "webView" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit/gtk/WebCoreSupport/InspectorClientGtk.h:79:  The parameter name "webInspector" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit/gtk/WebCoreSupport/InspectorClientGtk.h:79:  The parameter name "inspectorClient" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit/gtk/WebCoreSupport/InspectorClientGtk.h:96:  The parameter name "height" adds no information, so it should be removed.  [readability/parameter_name] [5]

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list