[Webkit-unassigned] [Bug 107131] [GTK] Implement testRunner::setTextDirection

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jan 18 01:52:15 PST 2013


https://bugs.webkit.org/show_bug.cgi?id=107131





--- Comment #6 from Manuel Rego Casasnovas <rego at igalia.com>  2013-01-18 01:54:03 PST ---
Thanks for your quick review yesterday :-)

I've just attached a new patch using gtk_widget_set_direction as proposed by Martin and it works properly.

BTW, just a brief comment about the previous patch. The implementation in the previous patch was based in chromium and efl implementations as you can check in: 
* Source/WebKit/efl/ewk/ewk_view.cpp: ewk_view_text_direction_set
* Source/WebKit/chromium/src/WebViewImpl.cpp: WebViewImpl::setTextDirection

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list