[Webkit-unassigned] [Bug 106811] Web Inspector: Add iframe option to inspectedWindow.eval() extension API

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=106811





--- Comment #12 from Andrey Kosyakov <caseq at chromium.org>  2013-01-17 07:18:07 PST ---
(From update of attachment 183058)
View in context: https://bugs.webkit.org/attachment.cgi?id=183058&action=review

> Source/WebCore/inspector/front-end/ExtensionServer.js:798
> +            if (options["useContentScriptContext"] === true) {

we use to check for just options["useContentScriptContext"]

> Source/WebCore/inspector/front-end/ExtensionServer.js:801
> +                frameSecurityOrigin = options.frame.securityOrigin;

Let's put securityOrigin on the top level of options. It's orthogonal to frame, you can also use it for top frame, i.e. without frame selector.
Also, flat options object will be easier to document. So I suggest three options on the top level:

- useContentScriptContext
- scriptExecutionContext (maps to your frame.securityOrigin; either overrides useContentScriptContext or mutually exclusive with it)
- frameURL (maps to frame.url)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.