[Webkit-unassigned] [Bug 106979] [EFL][WK2] Implement runBeforeUnloadConfirmPanel on EFL
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jan 16 00:06:42 PST 2013
https://bugs.webkit.org/show_bug.cgi?id=106979
Benjamin Poulain <benjamin at webkit.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #182921|review?, commit-queue? |review-, commit-queue-
Flag| |
--- Comment #2 from Benjamin Poulain <benjamin at webkit.org> 2013-01-16 00:08:26 PST ---
(From update of attachment 182921)
View in context: https://bugs.webkit.org/attachment.cgi?id=182921&action=review
> Source/WebKit2/ChangeLog:3
> + [EFL][WK2] Add support for onBeforeUnload handling
This title is confusing. Please update it.
> Source/WebKit2/ChangeLog:12
> + (WebKit):
You can remove this, it is likely generated from the namespace.
> Source/WebKit2/UIProcess/efl/PageUIClientEfl.cpp:231
>
> + uiClient.runBeforeUnloadConfirmPanel = runBeforeUnloadConfirmPanel;
> +
For clarity, you should keep those in the order of the PageUIClient.
> Source/WebKit2/UIProcess/efl/PageUIClientEfl.h:74
> + static bool runBeforeUnloadConfirmPanel(WKPageRef, WKStringRef, WKFrameRef, const void*);
ditto.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list