[Webkit-unassigned] [Bug 100341] [META][GTK] Implement threaded model of Coordinated Graphics

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 15 10:15:41 PST 2013


https://bugs.webkit.org/show_bug.cgi?id=100341





--- Comment #11 from WebKit Review Bot <webkit.review.bot at gmail.com>  2013-01-15 10:17:24 PST ---
Attachment 182799 did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/GNUmakefile.list.am', u'Sou..." exit_code: 1
Source/WebCore/platform/graphics/texmap/TextureMapperLayerThread.cpp:27:  Found other header before a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Source/WebCore/platform/graphics/texmap/TextureMapperLayerThread.cpp:29:  Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Source/WebCore/platform/graphics/texmap/TextureMapperLayerThread.cpp:69:  One line control clauses should not use braces.  [whitespace/braces] [4]
Source/WebCore/platform/graphics/texmap/TextureMapperLayerTask.cpp:26:  You should add a blank line after implementation file's own header.  [build/include_order] [4]
Source/WebCore/platform/graphics/texmap/TextureMapperLayerTask.cpp:83:  A case label should not be indented, but line up with its switch statement.  [whitespace/indent] [4]
Source/WebCore/platform/graphics/texmap/TextureMapperLayerThread.h:37:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Source/WebCore/platform/graphics/texmap/TextureMapperLayerTask.h:35:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Source/WebCore/platform/graphics/cairo/GLContext.h:52:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 8 in 12 files


If any of these errors are false positives, please file a bug against check-webkit-style.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list