[Webkit-unassigned] [Bug 106796] [TexMap] Composited CSS shaders crash when using non-GL TextureMapper

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=106796





--- Comment #3 from Allan Sandfeld Jensen <allan.jensen at digia.com>  2013-01-15 08:02:44 PST ---
(In reply to comment #2)
> (From update of attachment 182739 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=182739&action=review
> 
> > Source/WebCore/rendering/FilterEffectRenderer.cpp:424
> > +    if (!effect)
> > +        return;
> 
> By looking at the rest of FilterEffectRenderer, it looks like lastEffect is expected not to be null, so I'm not sure if this is the best fix longer term.
> It feels like none of this code makes sense if the list of effect is empty. Is there a way you could fix it at the caller?

The rest of the patch is fixing it at the caller, so this change on it is own is not needed to fix the crash (though it was here it crashed), but since a FilterEffectRenderer can be left "invalid" after a failed build() call, I felt it would be a good idea not to crash on a state that FilterEffectRenderer has left itself in.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.