[Webkit-unassigned] [Bug 103854] [META] Coordinated Graphics: Refactoring TextureMapper to work in an actor model

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=103854





--- Comment #4 from Huang Dongsung <luxtella at company100.net>  2013-01-15 03:38:16 PST ---
(From update of attachment 182686)
(In reply to comment #3)
> I think part of it you should already prepare, if you don't mind :)
> The part where we do all the syncing in GraphicsLayerTextureMapper instead of in TextureMapperLayer. If you want to prepare that and upstream I can do the other part where we use PODs instead of functional.

I want the fastest way. I don't want you to wait me. Feel free to use this patch. If we can work in parallel, I can complete this patch if you want.
Which is preferable? :)


View in context: https://bugs.webkit.org/attachment.cgi?id=182686&action=review

> Source/WebCore/platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:490
> +

btw, I'm not sure which granularity is optimal.
Coarse granularity makes POD big and reduces the number of dispatching message.
Fine granularity makes POD small and increases the number of dispatching message.
We need to find sweet point.

IMO CoordinatedGraphics::syncLayerState is a bit coarse. but below is a bit fine (e.g. ContentsRectChange, MasksToBoundsChange and etc.)

Do you have good solution?

Or will you correct the granularity if I land this patch with this problem?

 491    if (m_changeMask & ContentsRectChange)
 492        m_layer->appendChange(bind(&TextureMapperLayer::setContentsRect, m_layer.get(), contentsRect()));
 493
 494    if (m_changeMask & MasksToBoundsChange)
 495        m_layer->appendChange(bind(&TextureMapperLayer::setMasksToBounds, m_layer.get(), masksToBounds()));
 496
 497    if (m_changeMask & DrawsContentChange)
 498        m_layer->appendChange(bind(&TextureMapperLayer::setDrawsContent, m_layer.get(), drawsContent()));

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.