[Webkit-unassigned] [Bug 104835] Web Inspector: Don't throw exceptions in WebInspector.Color

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 15 00:48:29 PST 2013


https://bugs.webkit.org/show_bug.cgi?id=104835





--- Comment #11 from Yury Semikhatsky <yurys at chromium.org>  2013-01-15 00:50:16 PST ---
(From update of attachment 182597)
View in context: https://bugs.webkit.org/attachment.cgi?id=182597&action=review

> LayoutTests/inspector/styles/styles-invalid-color-values.html:39
> +            InspectorTest.addResult("invalid color '" + colorString + "' parses to null.");

I'd rather leave this function untouched and use another function (dumpInvalidColorRepresentations?) for invalid colors as they have inverted expectation compared to valid colors. With the current approach it is not clear if "invalid color 'rgba(255, 0, 0, 5)' parses to null." would be a wrong result.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list