[Webkit-unassigned] [Bug 105738] Remove Key3 & Challenge Response from WebInspector-NetworkPanel-HeaderTab for websocket

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=105738





--- Comment #11 from Kent Tamura <tkent at chromium.org>  2013-01-14 23:35:35 PST ---
(From update of attachment 182704)
View in context: https://bugs.webkit.org/attachment.cgi?id=182704&action=review

> Source/WebCore/ChangeLog:5
> +        Need the bug URL (OOPS!).

OOPS!  Remove this line.

> Source/WebCore/ChangeLog:12
> +        No new tests (OOPS!).

OOPS!.  Please replace this OOPS! with a reason why the patch has no tests.

> Source/WebCore/ChangeLog:31
> +        * Modules/websockets/WebSocketHandshakeRequest.cpp:
> +        * Modules/websockets/WebSocketHandshakeRequest.h:
> +        (WebSocketHandshakeRequest):
> +        * Modules/websockets/WebSocketHandshakeResponse.cpp:
> +        * Modules/websockets/WebSocketHandshakeResponse.h:
> +        (WebSocketHandshakeResponse):
> +        * inspector/Inspector.json:
> +        * inspector/InspectorResourceAgent.cpp:
> +        (WebCore):
> +        (WebCore::InspectorResourceAgent::willSendWebSocketHandshakeRequest):
> +        (WebCore::InspectorResourceAgent::didReceiveWebSocketHandshakeResponse):
> +        * inspector/front-end/NetworkManager.js:
> +        (WebInspector.NetworkDispatcher.prototype.webSocketWillSendHandshakeRequest):
> +        (WebInspector.NetworkDispatcher.prototype.webSocketHandshakeResponseReceived):
> +        * inspector/front-end/RequestHeadersView.js:
> +        (WebInspector.RequestHeadersView.prototype._refreshRequestHeaders):
> +        (WebInspector.RequestHeadersView.prototype._refreshResponseHeaders):
> +        (WebInspector.RequestHeadersView.prototype._refreshHeaders):

Please write per-file / per-function comments as possible.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.