[Webkit-unassigned] [Bug 106216] [EFL][WK2] Expose accessibility hierarchy in WebKit2-EFL.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Jan 14 18:16:54 PST 2013
https://bugs.webkit.org/show_bug.cgi?id=106216
--- Comment #14 from Gyuyoung Kim <gyuyoung.kim at samsung.com> 2013-01-14 18:18:40 PST ---
(From update of attachment 182546)
View in context: https://bugs.webkit.org/attachment.cgi?id=182546&action=review
> Source/WebKit2/PlatformEfl.cmake:121
> + WebProcess/WebPage/atk/WebPageAccessibilityObjectAtk.cpp
Wrong alphabetic order.
> Source/WebKit2/WebProcess/WebPage/WebPage.h:475
> +#if PLATFORM(GTK) || (PLATFORM(EFL) && HAVE(ACCESSIBILITY))
I wonder why EFL port only needs to use HAVE(ACCESSIBILITY) together. EFL port also enabled HAVE(ACCESSIBILITY) guard as GTK port.
#if !defined(HAVE_ACCESSIBILITY)
#if PLATFORM(IOS) || PLATFORM(MAC) || PLATFORM(WIN) || PLATFORM(GTK) || (PLATFORM(CHROMIUM) && !OS(ANDROID)) || PLATFORM(EFL)
#define HAVE_ACCESSIBILITY 1
#endif
> Source/WebKit2/WebProcess/WebPage/WebPage.h:849
> +#elif PLATFORM(GTK) || (PLATFORM(EFL) && HAVE(ACCESSIBILITY))
ditto.
> Source/WebKit2/WebProcess/WebPage/atk/WebPageAccessibilityObjectAtk.cpp:78
> +#if PLATFORM(EFL)
Is #if HAVE(ACCESSIBILITY) better for GTK port as well ?
> Source/WebKit2/WebProcess/WebPage/atk/WebPageAccessibilityObjectAtk.cpp:112
> +#if PLATFORM(EFL)
ditto ?
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list