[Webkit-unassigned] [Bug 105574] Fix scrollRectToVisible in the presence of transforms

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jan 14 18:15:36 PST 2013


Simon Fraser (smfr) <simon.fraser at apple.com> changed:

           What    |Removed                     |Added
 Attachment #182672|review?                     |review-
               Flag|                            |

--- Comment #18 from Simon Fraser (smfr) <simon.fraser at apple.com>  2013-01-14 18:17:23 PST ---
(From update of attachment 182672)
View in context: https://bugs.webkit.org/attachment.cgi?id=182672&action=review

Code changes are OK, but I think the tests could be improved.

> LayoutTests/ChangeLog:17
> +        * platform/chromium-linux/editing/input/reveal-caret-of-transformed-input-scrollable-parent-expected.png: Added.
> +        * platform/chromium-linux/editing/input/reveal-caret-of-transformed-input-scrollable-parent-expected.txt: Added.
> +        * platform/chromium-linux/editing/input/reveal-caret-of-transformed-multiline-input-expected.png: Added.
> +        * platform/chromium-linux/editing/input/reveal-caret-of-transformed-multiline-input-expected.txt: Added.

Can you make these ref tests, or fix them to use less text so that the results are more useful between platforms? Also, why do the expected images not use the mock scrollbar theme? Most platforms use that now.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list