[Webkit-unassigned] [Bug 105574] Fix scrollRectToVisible in the presence of transforms

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jan 14 17:21:02 PST 2013


https://bugs.webkit.org/show_bug.cgi?id=105574


Chris Hopman <cjhopman at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #182665|                            |commit-queue?
               Flag|                            |




--- Comment #15 from Chris Hopman <cjhopman at chromium.org>  2013-01-14 17:22:49 PST ---
(From update of attachment 182665)
The actual WebCore change is only very slightly changed from Patch #2 (the r+ one) to only convert to IntXXX when needed (I.e. changed to boundingBox() from enclosingBoundingBox()) and to use roundedIntRect() instead of enclosingIntRect() to be closer to the previous behavior.

The main change from patch #2 is that the tests were rewritten (because I thought the others were much too complicated).

Each of the test failures are 1 pixel changes in scroll offsets. At least for the suggestion-pickers this change appears to be for the better (i.e. more of the selected row is visible without exposing anything beyond it).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list