[Webkit-unassigned] [Bug 87993] window.internals is not good for changing persistent settings

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=87993





--- Comment #5 from Hajime Morrita <morrita at google.com>  2013-01-14 16:52:55 PST ---
Hi Tony,

(In reply to comment #4)
> Hi Alexey and Morria,
> 
> I was wondering what work remains for this bug.  Replying out of order:
I believe this can be closed. The concerns was addressed by Bug 88499.
I should have posted the patch here instead of Bug 88499.

(In reply to comment #0)
> 1. Changing a setting in one window.internals.settings object affects all frames in a page, but does not work across secondary windows. This is inconsistent.
> 

Now internals.settings is a supplement of a Page object.
It just provides a API for Page::settings() This is straightforward I think,
(RuntimeSettings might be tricky though.)


> 2. If a test navigates to a different URL (with waitUntilDone/notifyDone), settings are restored from last document's InternalSettings instead of first one's, so changes made in first one just leak to future tests.
> 

This one was fixed by Bug 88499. The state was reset for each test.

> 3. Code design is not very clear. Settings are per-page, yet many Internals methods take Document, Frame or a global context.

Well, this one could be improved. There are some method which takes a Document
as a first parameter. They could be eliminated. 
I don't think this blocks other bugs though.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.