[Webkit-unassigned] [Bug 78883] [GStreamer] AudioSourceProvider support in the MediaPlayer

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=78883





--- Comment #21 from Philippe Normand <pnormand at igalia.com>  2013-01-14 12:14:50 PST ---
(In reply to comment #20)
> (From update of attachment 181320 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=181320&action=review
> 
> Looks good in general
> 
> > Source/WebCore/platform/audio/gstreamer/AudioSourceProviderGStreamer.cpp:75
> > +    memcpy(bus->channel(channelNumber)->mutableData(), reinterpret_cast<float*>(info.data), info.size);
> 
> The reinterpret_cast here shouldn't be necessary
> 

Ok

> > Source/WebCore/platform/audio/gstreamer/AudioSourceProviderGStreamer.cpp:106
> > +    GstElement* audioSink = gst_element_factory_make("autoaudiosink", 0);
> 
> You might need a audioconvert and audioresample before/after the volume element
> 

Not sure to understand, both elements before and after volume?

> > Source/WebCore/platform/audio/gstreamer/AudioSourceProviderGStreamer.cpp:141
> > +        g_signal_handlers_disconnect_by_func(deinterleave.get(), reinterpret_cast<gpointer>(onGStreamerDeinterleaveReadyCallback), this);
> 
> It's far more efficient to store the signal handler IDs from g_signal_connect() and disconnect via them here

Ok I didn't know that :)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.