[Webkit-unassigned] [Bug 106745] [chromium/mac] In a webkit-in-chromium build, `run-webkit-tests --chromium` never uses binaries built by `build-webkit --chromium`

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Jan 13 11:00:49 PST 2013


https://bugs.webkit.org/show_bug.cgi?id=106745


Dirk Pranke <dpranke at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |eric at webkit.org,
                   |                            |tony at chromium.org




--- Comment #1 from Dirk Pranke <dpranke at chromium.org>  2013-01-13 11:02:38 PST ---
Correct, I wouldn't expect it to look there. 

Currently, the logic will look in what it thinks to be the top of the chromium checkout, and then the top of the webkit checkout. It would not know how to deal with two nested chromium checkouts. "the chromium checkout" is defined by looking at the path of the python file, so if we're in a webkit-in-chromium checkout, we'll always pick the enclosing chromium checkout, rather than the stuff added by update-webkit.

I'd actually be surprised if update-webkit --chromium even worked properly in this scenario (I guess maybe the correct thing to do would be to end up with two copies of the deps?). I'm not sure that there's a strong reason to support it.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list